[
https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867327#comment-13867327
]
Mark Miller commented on SOLR-5621:
-----------------------------------
I don't think we can flat out reject refactoring or code contributions because
they might destabilize code thats been around for a while. If we do that, Solr
will not evolve properly.
I sympathize with the idea that we don't want to add a lot of instability - I'm
fighting that battle with SolrCloud while it's still in it's hardening phase.
However, it's an argument that can easily be carried too far.
Honestly, I wouldn't be that happy to have such a big change in 5 that is not
in 4 - it starts making development and back porting a major pain. But the sad
fact is, this is exactly what 5.0 is for and all about.
I have not read the patch, so I don't know if I am for or against this, but
simply sharing code with Lucene adds to the contributors to the code, so flat
out, there are certainly some advantages. Perhaps some disadvantages too, but
without a doubt, advantages.
Anyway, I think we need to judge this on the technical merits of the final
patch.
> Let Solr use Lucene's SeacherManager
> ------------------------------------
>
> Key: SOLR-5621
> URL: https://issues.apache.org/jira/browse/SOLR-5621
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Fix For: 5.0
>
> Attachments: SOLR-5621.patch
>
>
> It would be nice if Solr could take advantage of Lucene's SearcherManager and
> get rid of most of the logic related to managing Searchers in SolrCore.
> I've been taking a look at how possible it is to achieve this, and even if I
> haven't finish with the changes (there are some use cases that are still not
> working exactly the same) it looks like it is possible to do. Some things
> still could use a lot of improvement (like the realtime searcher management)
> and some other not yet implemented, like Searchers on deck or
> IndexReaderFactory
> I'm attaching an initial patch (many TODOs yet).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
