[
https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867499#comment-13867499
]
Shai Erera commented on SOLR-5621:
----------------------------------
+1 for using SearcherManager. In fact, I think that Solr should make every
attempt to reuse whatever modules are in Lucene (including facet and replicator
for example). Duplicating code is useless and splits efforts of maintaining the
duplicates instead of concentrating on making one best module/code. I'd +1 any
such attempt in the future too.
As for code instability, this work can happen on a branch if we're so worried
it will make Solr that unstable. Maybe if it's a big feature it should be
developed in a branch anyway. I support Mark's statement - I prefer such big
changes to also release on the stable branch - but this is only my opinion, I
now some might argue that it's worth doing on the unstable branch only. A
branch lets us stabilize the change before they are merged to trunk and we can
then decide if they're worth porting to the stable branch as well or not.
> Let Solr use Lucene's SeacherManager
> ------------------------------------
>
> Key: SOLR-5621
> URL: https://issues.apache.org/jira/browse/SOLR-5621
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Fix For: 5.0
>
> Attachments: SOLR-5621.patch
>
>
> It would be nice if Solr could take advantage of Lucene's SearcherManager and
> get rid of most of the logic related to managing Searchers in SolrCore.
> I've been taking a look at how possible it is to achieve this, and even if I
> haven't finish with the changes (there are some use cases that are still not
> working exactly the same) it looks like it is possible to do. Some things
> still could use a lot of improvement (like the realtime searcher management)
> and some other not yet implemented, like Searchers on deck or
> IndexReaderFactory
> I'm attaching an initial patch (many TODOs yet).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
