[
https://issues.apache.org/jira/browse/SOLR-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875282#comment-13875282
]
Ryan Ernst commented on SOLR-5594:
----------------------------------
{quote}
Fixed the reformatting, however as things have moved (and there's been a level
change.. new inner classes etc) it still looks a little tricky but yes, it's no
longer just reformatted code in the patch.
{quote}
Why are any of the changes in SimpleQParser necessary, except for changing
{{new PrefixQuery(...)}} to {{sf.getType().getPrefixQuery()}}? It looks like
all the other changes there are unnecessary structural changes. Since the
{{IndexSchema}} is already available, it should be just a couple lines changed
(180/183).
Why not just make the necessary changes for this issue, and open another jira
if you feel static inner classes would be better here (although I don't see why
two are necessary)?
> Enable using extended field types with prefix queries for non-default encoded
> strings
> -------------------------------------------------------------------------------------
>
> Key: SOLR-5594
> URL: https://issues.apache.org/jira/browse/SOLR-5594
> Project: Solr
> Issue Type: Improvement
> Components: query parsers, Schema and Analysis
> Affects Versions: 4.6
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Minor
> Attachments: SOLR-5594-branch_4x.patch, SOLR-5594.patch,
> SOLR-5594.patch, SOLR-5594.patch, SOLR-5594.patch
>
>
> Enable users to be able to use prefix query with custom field types with
> non-default encoding/decoding for queries more easily. e.g. having a custom
> field work with base64 encoded query strings.
> Currently, the workaround for it is to have the override at getRewriteMethod
> level. Perhaps having the prefixQuery also use the calling FieldType's
> readableToIndexed method would work better.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
