[ 
https://issues.apache.org/jira/browse/SOLR-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875349#comment-13875349
 ] 

Uwe Schindler commented on SOLR-5594:
-------------------------------------

bq. SolrQueryParserBase.newPrefixQuery shouldnt' be removed completely (it's 
protected, subclasses might be using it) ... just update it to call the new 
method on the FieldType.

bq. Why are any of the changes in SimpleQParser necessary, except for changing 
new PrefixQuery(...) to sf.getType().getPrefixQuery()? It looks like all the 
other changes there are unnecessary structural changes. Since the IndexSchema 
is already available, it should be just a couple lines changed (180/183).

Yes, this would also be identical to range query behaviour: newRangeQuery also 
delegates to the field type, and the protected method is there for subclasses.

> Enable using extended field types with prefix queries for non-default encoded 
> strings
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-5594
>                 URL: https://issues.apache.org/jira/browse/SOLR-5594
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers, Schema and Analysis
>    Affects Versions: 4.6
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>         Attachments: SOLR-5594-branch_4x.patch, SOLR-5594.patch, 
> SOLR-5594.patch, SOLR-5594.patch, SOLR-5594.patch
>
>
> Enable users to be able to use prefix query with custom field types with 
> non-default encoding/decoding for queries more easily. e.g. having a custom 
> field work with base64 encoded query strings.
> Currently, the workaround for it is to have the override at getRewriteMethod 
> level. Perhaps having the prefixQuery also use the calling FieldType's 
> readableToIndexed method would work better.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to