[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883171#comment-13883171
]
Shalin Shekhar Mangar commented on SOLR-5473:
---------------------------------------------
Some comments on the latest patch:
# AbstractFullDistribZkTestBase has a useExternalCollection() which is hard
coded to false. Why? Can we randomize using external collections in the base
test to have better test coverage?
# ClusterState.getCollections has a todo which says “fix later JUnit is
failing”. Which test is failing?
# What is _stateVer_ used for? I guess it is for SOLR-5474 and not this issue?
# This patch has only whitespace related changes to CloudSolrServer.
# There is wrong formatting and incorrect spacing in the new code such as
Overseer.createCollection, new methods in ClusterState etc. You should
re-format all the new/modified code blocks
# There was one forbidden-api check failure where new String(byte[])
constructor is used in a log message. Run ant check-forbidden-apis from inside
the solr directory.
# There are three javadoc errors (run ant precommit):
{code}
[ecj-lint] 1. ERROR in
/Users/shalinmangar/work/oss/solr-trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
(at line 199)
[ecj-lint] /** @deprecated
[ecj-lint] ^^^^^^^^^^
[ecj-lint] Javadoc: Description expected after @deprecated
[ecj-lint] ----------
[ecj-lint] 2. ERROR in
/Users/shalinmangar/work/oss/solr-trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
(at line 297)
[ecj-lint] * @deprecated
[ecj-lint] ^^^^^^^^^^
[ecj-lint] Javadoc: Description expected after @deprecated
[ecj-lint] ----------
[ecj-lint] ----------
[ecj-lint] 3. ERROR in
/Users/shalinmangar/work/oss/solr-trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
(at line 759)
[ecj-lint] * @param coll
[ecj-lint] ^^^^
[ecj-lint] Javadoc: Description expected after this reference
[ecj-lint] ----------
[ecj-lint] 3 problems (3 errors)
{code}
> Make one state.json per collection
> ----------------------------------
>
> Key: SOLR-5473
> URL: https://issues.apache.org/jira/browse/SOLR-5473
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Noble Paul
> Assignee: Noble Paul
> Attachments: SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch
>
>
> As defined in the parent issue, store the states of each collection under
> /collections/collectionname/state.json node
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
