[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885418#comment-13885418
]
Shalin Shekhar Mangar commented on SOLR-5473:
---------------------------------------------
Two comments specific to the SOLR-5474 part which has been included in the
latest patch:
# The ExpireOnGetHashMap is not thread-safe. The eviction logic in
ExpireOnGetHashMap synchronises on ‘this’ but that is insufficient. The
requestWithRetryOnStaleState method calls put and remove without synchronizing
on the map so it is open to a ConcurrentModificationException. I think we can
just extend ConcurrentHashMap instead and not worry about synchronisation at
all.
# Now that we have eliminated LazyCloudSolrServer, the method signature changes
from private to protected are no longer necessary.
> Make one state.json per collection
> ----------------------------------
>
> Key: SOLR-5473
> URL: https://issues.apache.org/jira/browse/SOLR-5473
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Noble Paul
> Assignee: Noble Paul
> Attachments: SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch
>
>
> As defined in the parent issue, store the states of each collection under
> /collections/collectionname/state.json node
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
