[
https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888676#comment-13888676
]
Shai Erera edited comment on LUCENE-5425 at 2/1/14 7:07 PM:
------------------------------------------------------------
bq. Shai, given that using OBS Iterator performance is the same as trunk, do
you think we should move forward and change to the DocIdSet api or do you still
think we should split up as 2 different issues.
Honestly, I don't think the lucene/benchmark package is as good as luceneutil,
especially not when it comes to queries. luceneutil tries different queries,
combining low/high freq terms, span queries and what not, and so the results
that we get there are more stable and reflect the benefits/drawback of the
change across a wider spectrum. Lei, I apologize for not mentioning that
before, if it wasted your time. It seemed obvious to me :).
But the cut to DocIdSet is bigger than just allowing to reuse FixedBitSet, so
why not split the issue to two separate ones anyway? Like, if it turns out that
DocIdSet as an abstraction is not bad, but the iterator is, we can always do an
instanceof check and execute the more optimized code. So let's just explore all
that in a separate issue? Or, if you prefer to do it all in one issue, then we
should get luceneutil's blessing here :).
was (Author: shaie):
bq. Shai, given that using OBS Iterator performance is the same as trunk, do
you think we should move forward and change to the DocIdSet api or do you still
think we should split up as 2 different issues.
Honestly, I don't think the lucene/benchmark package is as good as luceneutil,
especially not when it comes to queries. luceneutil tries different queries,
combining low/high freq terms, span queries and what not, and so the results
that we get there are more stable and reflect the benefits/drawback of the
change across a wider spectrum. Lei, I apologize for not mentioning that
before, if it wasted your time. It seemed obvious to me :).
> Make creation of FixedBitSet in FacetsCollector overridable
> -----------------------------------------------------------
>
> Key: LUCENE-5425
> URL: https://issues.apache.org/jira/browse/LUCENE-5425
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 4.6
> Reporter: John Wang
> Attachments: facetscollector.patch, facetscollector.patch
>
>
> In FacetsCollector, creation of bits in MatchingDocs are allocated per query.
> For large indexes where maxDocs are large creating a bitset of maxDoc bits
> will be expensive and would great a lot of garbage.
> Attached patch is to allow for this allocation customizable while maintaining
> current behavior.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
