[
https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895977#comment-13895977
]
Uwe Schindler edited comment on LUCENE-5425 at 2/9/14 6:46 PM:
---------------------------------------------------------------
Hi,
unfortunately the methods FixedBitSet.or(DocIdSetIterator) now can no longer
use the optimization. We should refactor the anaonymous iterator to be a
pkg-private class and change the instanceof checks in the and/or/.... methods
use that class.
BooleanFilter and ChainedFilter make heavy use of this opto!!!
was (Author: thetaphi):
Hi,
unfortunately the methods FixedBitSet.or(DocIdSetIterator) now can no longer
use the optimization. We should refactor the anaonymous iterator to be a
pkg-private class and change the instanceof checks in the and/or/.... methods
use that class.
> Make creation of FixedBitSet in FacetsCollector overridable
> -----------------------------------------------------------
>
> Key: LUCENE-5425
> URL: https://issues.apache.org/jira/browse/LUCENE-5425
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: 4.6
> Reporter: John Wang
> Assignee: Shai Erera
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5425.patch, facetscollector.patch,
> facetscollector.patch, fixbitset.patch
>
>
> In FacetsCollector, creation of bits in MatchingDocs are allocated per query.
> For large indexes where maxDocs are large creating a bitset of maxDoc bits
> will be expensive and would great a lot of garbage.
> Attached patch is to allow for this allocation customizable while maintaining
> current behavior.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
