[ 
https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937853#comment-13937853
 ] 

Furkan KAMACI commented on SOLR-5852:
-------------------------------------

[~elyograg] ConnectStringParser at Zookeeper checks chroot and other invalid 
situations. We can give that checking responsibility to Zookeeper. If anything 
changes within Zookeeper check condition our CloudSolrServer will not be 
affected from it because we will pass that check to Zookeeper and it will 
handle it.

I think that we can handle chroot with current situation too. Zookeeper.java 
works like that: 127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002/app/a so I can 
improve the javadoc and include that: if there is a chroot add it to the end of 
the last host string (this is how original Zookeeper code works). All in all if 
anybody sends multiple chroot definitions or anything else Zookeeper will 
return an error.

Another approach is accepting like that: 
127.0.0.1:3000/app/a,127.0.0.1:3001/app/a,127.0.0.1:3002/app/a so parsing if 
there any chroot and valid for all hosts etc.

> Add CloudSolrServer helper method to connect to a ZK ensemble
> -------------------------------------------------------------
>
>                 Key: SOLR-5852
>                 URL: https://issues.apache.org/jira/browse/SOLR-5852
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>         Attachments: SOLR-5852.patch, SOLR-5852_FK.patch
>
>
> We should have a CloudSolrServer constructor which takes a list of ZK servers 
> to connect to.
> Something Like 
> {noformat}
> public CloudSolrServer(String... zkHost);
> {noformat}
> - Document the current constructor better to mention that to connect to a ZK 
> ensemble you can pass a comma-delimited list of ZK servers like 
> zk1:2181,zk2:2181,zk3:2181
> - Thirdly should getLbServer() and getZKStatereader() be public?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to