[
https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941974#comment-13941974
]
Erick Erickson commented on SOLR-5852:
--------------------------------------
As I read this, I don't quite see the utility of offering all the different ways
of specifying the ensemble.
1> ("host1:2181", "/mychroot")
2> ("127.0.0.1:3000", "127.0.0.1:3001", "127.0.0.1:3002")
3> ("localhost:2181", "localhost:2181", "localhost:2181/solrtwo")
4> ("zoo1:2181", "zoo2:2181", "zoo3:2181", "/solr-three")
5> ("zoo1.example.com:2181",
"zoo2.example.com:2181","zoo3.example/com:2181","/solr-three")
6> ("zoo1:2181/root", "zoo2:2181/root", "zoo3:2181/root")
Aren't these all handled by the "typical" ZK ensemble connection string? I.e.
1> "host1:2101/mychroot"
2> "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002"
3> "localhost:2181,localhost:2181,localhost:2181/solrtwo"
4> like 3
5> like 3
6> like 3
I confess I'm just looking at it from a rather ignorant level, but it seems
like this would add complexity for no added functionality. Of course I may be
missing a lot, if there are places where this kind of processing is
_already_ being done and this moves things to a c'tor that would
be a reason.
I'd rather have a single form than multiple forms, unless the multiple
forms give me added functionality. Otherwise, one adds maintenance
without adding value..
Let me know if I've missed the boat here.
> Add CloudSolrServer helper method to connect to a ZK ensemble
> -------------------------------------------------------------
>
> Key: SOLR-5852
> URL: https://issues.apache.org/jira/browse/SOLR-5852
> Project: Solr
> Issue Type: Improvement
> Reporter: Varun Thacker
> Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch,
> SOLR-5852_FK.patch, SOLR-5852_FK.patch
>
>
> We should have a CloudSolrServer constructor which takes a list of ZK servers
> to connect to.
> Something Like
> {noformat}
> public CloudSolrServer(String... zkHost);
> {noformat}
> - Document the current constructor better to mention that to connect to a ZK
> ensemble you can pass a comma-delimited list of ZK servers like
> zk1:2181,zk2:2181,zk3:2181
> - Thirdly should getLbServer() and getZKStatereader() be public?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
