[
https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943613#comment-13943613
]
Furkan KAMACI commented on SOLR-5852:
-------------------------------------
bq. Yeah, I can live with that 'cause it doesn't require regexes, or really any
complex logic.
I think so. I tried to explain same idea that we should pass it to Zookeeper
class. Because if any logic changes within Zookeeper class we have to change
our constructor too.
bq. (String chroot, List<String> hosts)
this is a nice signature for us.
It is not important but: (List<String> hosts, String chroot) maybe good
because of chroot is not mandatory and it seems me more human readeble not to
pass a null value at first paramater. Also there may be a signature as like
(List<String> hosts) too for whom does not use a chroot parameter.
> Add CloudSolrServer helper method to connect to a ZK ensemble
> -------------------------------------------------------------
>
> Key: SOLR-5852
> URL: https://issues.apache.org/jira/browse/SOLR-5852
> Project: Solr
> Issue Type: Improvement
> Reporter: Varun Thacker
> Attachments: SOLR-5852-SH.patch, SOLR-5852-SH.patch, SOLR-5852.patch,
> SOLR-5852_FK.patch, SOLR-5852_FK.patch
>
>
> We should have a CloudSolrServer constructor which takes a list of ZK servers
> to connect to.
> Something Like
> {noformat}
> public CloudSolrServer(String... zkHost);
> {noformat}
> - Document the current constructor better to mention that to connect to a ZK
> ensemble you can pass a comma-delimited list of ZK servers like
> zk1:2181,zk2:2181,zk3:2181
> - Thirdly should getLbServer() and getZKStatereader() be public?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
