[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951642#comment-13951642
]
Anshum Gupta commented on SOLR-5473:
------------------------------------
More comments:
# Removing the commented out code would be good:
{code:title=ZkStateReader.java|borderStyle=solid}
@@ -283,6 +298,12 @@
ClusterState clusterState = ClusterState.load(stat.getVersion(),
data, ln,ZkStateReader.this);
// update volatile
ZkStateReader.this.clusterState = clusterState;
+
+ updateCollectionNames();
+// HashSet<String> all = new HashSet<>(colls);;
+// all.addAll(clusterState.getAllInternalCollections());
+// all.remove(null);
+
{code}
# The following code reverts changes from SOLR-5770
{code:title=ClusterState.json}
@@ -198,16 +210,28 @@
- public String getShardId(String nodeName, String coreName) {
+
public String getShardId(String collectionName, String baseUrl, String
coreName) {
{code}
# Can we change the new method signature from “DocCollection(version,name,
slices, props, router)” to “DocCollection(name, slices, props, router,
version)” ? I understand it’s more superficial but it looks better to have
extended method signature grow to the right.
# Can you put the “// clean work queue” comment back in the code in
Overseer.java?
# The indentation (primarily spaces) seems off at a few places. Would be good
to fix that.
# Seems like this would not work for extern collections. Do you plan to handle
this before you commit?
{code:title=Assign.java}
if(c == null) continue; //TODO check this later
{code}
> Make one state.json per collection
> ----------------------------------
>
> Key: SOLR-5473
> URL: https://issues.apache.org/jira/browse/SOLR-5473
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Noble Paul
> Assignee: Noble Paul
> Attachments: SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, ec2-23-20-119-52_solr.log,
> ec2-50-16-38-73_solr.log
>
>
> As defined in the parent issue, store the states of each collection under
> /collections/collectionname/state.json node
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
