[
https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990267#comment-13990267
]
Robert Muir commented on LUCENE-5645:
-------------------------------------
I'm not sure. If tests.seed is empty, then things won't reproduce right?
Because it will initialize itsself with System.currentTimeMillis().
So perhaps the exception is actually warranted. Is there really a better
exception we can give than the current one (i assume NumberFormatException as
it tries to parse the empty string)? I think thats appropriate.
> StringHelper should check for empty string of "tests.seed" system property
> --------------------------------------------------------------------------
>
> Key: LUCENE-5645
> URL: https://issues.apache.org/jira/browse/LUCENE-5645
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.8, 5.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 4.8.1, 5.0
>
>
> As of LUCENE-5604 (committed to v4.8), StringHelper will initialize
> GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set.
> Unfortunately it doesn't do an empty-string check, and it's common at least
> in my setup that copies Lucene's maven pom.xml that the string will be empty
> unless I set it on the command line. FWIW Randomized Testing does do an
> empty-string check.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
