[
https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013428#comment-14013428
]
Robert Muir commented on LUCENE-5645:
-------------------------------------
I'm still confused: since when was the empty string a supported value for
'tests.seed'? I don't think it should be: its unnecessary and just makes the
test framework complicated. I'm not sure it will even really "work".
its sad that StringHelper gets the blame here, LuceneTestCase should have
thrown an exception earlier.
> StringHelper should check for empty string of "tests.seed" system property
> --------------------------------------------------------------------------
>
> Key: LUCENE-5645
> URL: https://issues.apache.org/jira/browse/LUCENE-5645
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.8, 5.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 4.8.1, 5.0
>
> Attachments: LUCENE-5645_StringHelper_empty_tests_seed_condition.patch
>
>
> As of LUCENE-5604 (committed to v4.8), StringHelper will initialize
> GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set.
> Unfortunately it doesn't do an empty-string check, and it's common at least
> in my setup that copies Lucene's maven pom.xml that the string will be empty
> unless I set it on the command line. FWIW Randomized Testing does do an
> empty-string check.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
