[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003580#comment-14003580 ]
Robert Muir commented on LUCENE-5689: ------------------------------------- It maybe, i wasnt sure about the implications of that. I think we should first remove the 'public', because I do not know what will happen if someone invokes this setter on e.g. AtomicReader, but I'm guessing its not good :) > FieldInfo.setDocValuesGen should not be public. > ----------------------------------------------- > > Key: LUCENE-5689 > URL: https://issues.apache.org/jira/browse/LUCENE-5689 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Attachments: LUCENE-5689.patch > > > its currently public and users can modify it. We made this class mostly > immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org