[
https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004557#comment-14004557
]
Shai Erera commented on LUCENE-5689:
------------------------------------
ReaderAndUpdates already clones all FIs and then updates the dvGen of the ones
that are updated now. So cloning again is silly ... perhaps we can get rid of
it some day, but I agree, let's remove the public first. And yes, if you modify
the dvGen on an AtomicReader, you might hit weird exceptions like FNFE when the
reader will try to lookup the field's dv-gen'd file.
> FieldInfo.setDocValuesGen should not be public.
> -----------------------------------------------
>
> Key: LUCENE-5689
> URL: https://issues.apache.org/jira/browse/LUCENE-5689
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5689.patch
>
>
> its currently public and users can modify it. We made this class mostly
> immutable long ago: remember its returned by the atomicreader API!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
