[
https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-6119:
--------------------------------
Attachment: SOLR-6119.patch
Patch which fixes the test.
- Renamed snapDir to snapDirs to make it more evident that this test creates 2
backups in each run.
- Fixed
{code}boolean namedBackup = true;{code} to {code}boolean namedBackup =
random().nextBoolean();{code}
- Fixed 2 logical mistakes in the test
- Revision 1598013 changed the logic in the finally block by trying to delete
snapDir instead of each of the directories. Fixed this.
I ran {noformat} ant test -Dtestcase=TestReplicationHandler
-Dtests.method=doTestBackup -Dtests.seed=55ADF081A0AD0544 -Dtests.multiplier=3
-Dtests.slow=true -Dtests.locale=fr_FR -Dtests.timezone=America/Lower_Princes
-Dtests.file.encoding=US-ASCII{noformat} which was reported by the Jenkins
failures and it passed for me after the patch
> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
> Key: SOLR-6119
> URL: https://issues.apache.org/jira/browse/SOLR-6119
> Project: Solr
> Issue Type: Bug
> Reporter: Dawid Weiss
> Priority: Minor
> Attachments: SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It
> attempts to remove snapshot folders, even though they're not closed yet. My
> recent patch uncovered the bug but I don't know how to fix it cleanly -- the
> test itself seems to be very fragile (for example I don't understand the
> 'namedBackup' variable which is always set to true, yet there are
> conditionals around it).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
