[ 
https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-6119:
--------------------------------

    Attachment: SOLR-6119.patch

{noformat}
[junit4] FAILURE 3.05s J1 | TestReplicationHandler.doTestBackup <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: expected:<1> but 
was:<2>
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([227BE1FA9CDC834F:63F0C19FBB627000]:0)
   [junit4]    >        at 
org.apache.solr.handler.TestReplicationHandler.doTestBackup(TestReplicationHandler.java:1513)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
{noformat}

The file names created are - q and qjxiogjoksvtiijnlhhm and the test conditon 
{code}  if (name.startsWith("snapshot." + backupName)) { {code} should have 
been equals.

Patch which fixes this.

Updating the patch against branch_4x.

> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
>                 Key: SOLR-6119
>                 URL: https://issues.apache.org/jira/browse/SOLR-6119
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Minor
>         Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch, 
> SOLR-6119.patch, SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It 
> attempts to remove snapshot folders, even though they're not closed yet. My 
> recent patch uncovered the bug but I don't know how to fix it cleanly -- the 
> test itself seems to be very fragile (for example I don't understand the 
> 'namedBackup' variable which is always set to true, yet there are 
> conditionals around it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to