Actually, in trunk IW doesn't break on anything else. There's one private no-longer-used method I forgot to delete on my drop-all-deprecations spree. And there's a block in addIndexes, that explicitly checks instanceof, and only then casts to LMP.
I'm against consolidating MP and LMP. MP is a damn interface! We should strive to make things less coupled rather than other way around. On Thu, Dec 2, 2010 at 12:25, Shai Erera <ser...@gmail.com> wrote: > Hi > > While IndexWriter declares it accepts a general MP, it will actually fail if > the given instance is not LogMP. So I wonder if we shouldn't consolidate > both of them into one, and pull up all of LMP features to MP. I think all of > LMP's features are useful for any kind of MP, and if someone wants to ignore > them he still can. > > This is not the sort of change that fits well in trunk. IMO it can fit well > in 3x too since IW didn't accept anything that is not LMP. So even if it > will appear we're breaking back-compat, we actually won't. Which is another > reason, for me, why those two should be consolidated. > > What do you think? > > Shai > -- Kirill Zakharenko/Кирилл Захаренко (ear...@gmail.com) Phone: +7 (495) 683-567-4 ICQ: 104465785 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
