[ 
https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017024#comment-14017024
 ] 

Varun Thacker commented on SOLR-6119:
-------------------------------------

Dawid, Thanks for the detailed explanation.

Looks like the main problem is doTestBackup() is not a Replication test. All 
the other tests in this class use 2 Jettys ( masterJetty and slaveJetty ) and 
have replication tests. doTestBackup()  is testing index backups and deletes.

{code}
2830 T38 oash.SnapPuller.fetchLatestIndex ERROR Master at: 
http://127.0.0.1:55584/solr is not 
{code}

These are calls made from the slaveJetty trying to connect to the masterJetty. 
But in doTestBackup like many other tests in the suite we restart masterJetty 
after which slaveJetty is unable to connect to the old master anymore. The 
other tests stop and start the slaveJetty after the master has been restarted 
correctly thus the problem is not seen.

So there are two solutions - 
1. stop/start the slave jetty in doTestBackup() for it to connect to the new 
master jetty.
2. break it out into another test class where slave jetty won't be required.

> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
>                 Key: SOLR-6119
>                 URL: https://issues.apache.org/jira/browse/SOLR-6119
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Minor
>         Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch, 
> SOLR-6119.patch, SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It 
> attempts to remove snapshot folders, even though they're not closed yet. My 
> recent patch uncovered the bug but I don't know how to fix it cleanly -- the 
> test itself seems to be very fragile (for example I don't understand the 
> 'namedBackup' variable which is always set to true, yet there are 
> conditionals around it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to