[ https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017043#comment-14017043 ]
Dawid Weiss commented on SOLR-6119: ----------------------------------- Thanks for clarifying, Varun. I think we can leave the test in the same class, but at least shut down the slave jetty and provide a single-line comment of what those shutdowns are for (in the code). I'm sure it'll be of help in the future for somebody browsing through the code! > TestReplicationHandler attempts to remove open folders > ------------------------------------------------------ > > Key: SOLR-6119 > URL: https://issues.apache.org/jira/browse/SOLR-6119 > Project: Solr > Issue Type: Bug > Reporter: Dawid Weiss > Priority: Minor > Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch, > SOLR-6119.patch, SOLR-6119.patch > > > TestReplicationHandler has a weird logic around the 'snapDir' variable. It > attempts to remove snapshot folders, even though they're not closed yet. My > recent patch uncovered the bug but I don't know how to fix it cleanly -- the > test itself seems to be very fragile (for example I don't understand the > 'namedBackup' variable which is always set to true, yet there are > conditionals around it). -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org