[ https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-2894: --------------------------- Attachment: SOLR-2894.patch bq. I definitely want to add some test logic around that – if for no other reason then to prove that when the overrequesting is used, it can help with finding constraints in the long tail Updated patch... * new DistributedFacetPivotLongTailTest ** crafts the shard distribution specifically to demonstrate that overrequesting is affecting things as expected * split DistributedFacetPivotTest into DistributedFacetPivotSmallTest and DistributedFacetPivotLargeTest ** this was already 2 very different sets of data with two very differnet styles of asserting expected results -- so i went ahead and split it up ** Now there isn't the weird suprise that halfway through a test all the data is deleted and new data is added and more asertions are made. Brett & Andrew: would really appreciate if you guys could review my changes to your existing test as well as the new LongTail test and help sanity check that the assertions all look correct. Assuming you guys don't spot any problems with the tests: next up i'll move back into reviewing the code more in depth, and documenting/refactoring/unit-testing as needed to help myself understand all this awesomeness you guys have added. > Implement distributed pivot faceting > ------------------------------------ > > Key: SOLR-2894 > URL: https://issues.apache.org/jira/browse/SOLR-2894 > Project: Solr > Issue Type: Improvement > Reporter: Erik Hatcher > Fix For: 4.9, 5.0 > > Attachments: SOLR-2894-mincount-minification.patch, > SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, > SOLR-2894_cloud_test.patch, dateToObject.patch, pivot_mincount_problem.sh > > > Following up on SOLR-792, pivot faceting currently only supports > undistributed mode. Distributed pivot faceting needs to be implemented. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org