[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Muldowney updated SOLR-2894:
-----------------------------------
Attachment: SOLR-2894.patch
bq. Just to clarify: you are saying that bbc isn't included in the "top" set in
the distrib call because overrequest is so low, which is inconcsistent with the
control where bbc is in the top – but all of the values returned by the distrib
call do in fact have accurate refined counts ... correct?
It *was* not refining properly, which I attributed to the lack of overrequest
but that was incorrect. The test is actually the only one that tests the
following criteria:
* A value that should be in the "top" elements is not because the
overrequesting didn't pick it up or too many shards had values too small. (In
this case {{"bbc"}} only has a value of 150 from the initial round, when its
actual value is 445, larger than {{microsoft}}'s inital value of 398)
* There is a shard that has responded with an empty response, aka it has no
documents (shard#3 is always empty in the long test file)
When those two things combine we had an error in our refinement code where we
would add {{Integer.MAX_VALUE}} to the possible count, overflowing the {{int}}
and causing it to go negative, and we would never ask for refinement. So we
would get {{microsoft:398}} over {{bbc}} *Fixed*
I have fixed the null issue that keeps away from counting towards the
{{facet.limit}}
I have fixed the null issue that keeps it around even when its less than
{{facet.mincount}}
I have fixed the issue where an empty response from a shard would render all
values on the cusp of making it into the top values never get refined.
Are you still seeing the infinite recursion problem? The seeds you provided
earlier pass locally for me.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894_cloud_test.patch, dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
