[ https://issues.apache.org/jira/browse/LUCENE-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034453#comment-14034453 ]
David Smiley commented on LUCENE-5714: -------------------------------------- Progress report: * I added an onslaught of randomized testing and it uncovered dateline edge cases (e.g. touches but doesn't cross the dateline) and world-wrap (-180 to 180) bugs that I fixed. * Simplified queries that weren't used in a geospatial context (no need to check dateline cross) * Removed supposed support for the Overlaps predicate, as it was written as identical to Intersects. This strategy never truly supported Overlaps even if it didn't complain. If someone wants it; create an issue and ideally upload the code too :-) Next up is Similarity testing. > Improve tests for BBoxStrategy then port to 4x. > ----------------------------------------------- > > Key: LUCENE-5714 > URL: https://issues.apache.org/jira/browse/LUCENE-5714 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial > Reporter: David Smiley > Assignee: David Smiley > Fix For: 4.9 > > > BBoxStrategy needs better tests before I'm comfortable seeing it in 4x. > Specifically it should use random rectangles based validation (ones that may > cross the dateline), akin to the other tests. And I think I see an > equals/hashcode bug to be fixed in there too. > One particular thing I'd like to see added is how to handle a zero-area case > for AreaSimilarity. I think an additional feature in which you declare a > minimum % area (relative to the query shape) would be good. > It should be possible for the user to combine rectangle center-point to query > shape center-point distance sorting as well. I think it is but I need to > make sure it's possible without _having_ to index a separate center point > field. > Another possibility (probably not to be addressed here) is a minimum ratio > between width/height, perhaps 10%. A long but nearly no height line should > not be massively disadvantaged relevancy-wise to an equivalently long > diagonal road that has a square bbox. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org