[
https://issues.apache.org/jira/browse/LUCENE-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055805#comment-14055805
]
David Smiley commented on LUCENE-5714:
--------------------------------------
On additional thing I'd like to get in is to auto-extract the bounding box of a
provided shape instead of throwing an error. It's not like this behavior would
be unexpected; if you use this field it's quite intuitive that if you provide
any old shape, it's going to index the bounding box. The current code is
simply:
{code:java}
public Field[] createIndexableFields(Shape shape) {
if (shape instanceof Rectangle)
return createIndexableFields((Rectangle)shape);
throw new UnsupportedOperationException("Can only index a Rectangle, not "
+ shape);
}
{code}
Instead it would be:
{code:java}
public Field[] createIndexableFields(Shape shape) {
return createIndexableFields(shape.getBoundingBox());
}
{code}
Rectangle.getBoundingBox() returns "this", by the way.
> Improve tests for BBoxStrategy then port to 4x.
> -----------------------------------------------
>
> Key: LUCENE-5714
> URL: https://issues.apache.org/jira/browse/LUCENE-5714
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5714_Enhance_BBoxStrategy.patch,
> LUCENE-5714__Enhance_BBoxStrategy__more_tests,_fix_dateline_bugs,_new_AreaSimilarity_algor.patch
>
>
> BBoxStrategy needs better tests before I'm comfortable seeing it in 4x.
> Specifically it should use random rectangles based validation (ones that may
> cross the dateline), akin to the other tests. And I think I see an
> equals/hashcode bug to be fixed in there too.
> One particular thing I'd like to see added is how to handle a zero-area case
> for AreaSimilarity. I think an additional feature in which you declare a
> minimum % area (relative to the query shape) would be good.
> It should be possible for the user to combine rectangle center-point to query
> shape center-point distance sorting as well. I think it is but I need to
> make sure it's possible without _having_ to index a separate center point
> field.
> Another possibility (probably not to be addressed here) is a minimum ratio
> between width/height, perhaps 10%. A long but nearly no height line should
> not be massively disadvantaged relevancy-wise to an equivalently long
> diagonal road that has a square bbox.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
