[ https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050665#comment-14050665 ]
Mark Miller commented on SOLR-5473: ----------------------------------- bq. It is crazy that it takes a commit to get your attention It's simply when I could push it off no longer. As you have seen, I have not been active in Solr for a while now. It's unfortunate, but it is what it is. Now is when I was able to take a look. My point is not simply the ZkStateReader - thats one of the more terrible changes I think, but much worse it was it does to the api's in general, how messy the change is in general, and how it complicates and weakens the code IMO. I have given constructive thoughts on why the API's are bad and what needs to be done or what might be an idea to try. I can't hold your hand down that entire path though - I have my own work schedule and priorities unfortunately. I can honestly say these look like really bad changes to me though, and I have to try and preserve SolrCloud where I can. I see more and more tests failing since I left, Noble has a track record of introducing tests that fail a lot with SolrCloud, and a *ton* of what I brought up was not addressed at all. A lot of SolrCloud issues go in that I don't fully support or think is ready 100%. I'm not trying to be a dick to work with. I do think this work is not very good yet and that putting it in trunk will be a huge pain down the line and so I can't let it happen is my position. > Make one state.json per collection > ---------------------------------- > > Key: SOLR-5473 > URL: https://issues.apache.org/jira/browse/SOLR-5473 > Project: Solr > Issue Type: Sub-task > Components: SolrCloud > Reporter: Noble Paul > Assignee: Noble Paul > Fix For: 5.0 > > Attachments: SOLR-5473-74 .patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, > SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-configname-fix.patch, > SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, > SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, > SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, > SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, > SOLR-5473.patch, SOLR-5473.patch, SOLR-5473_undo.patch, > ec2-23-20-119-52_solr.log, ec2-50-16-38-73_solr.log > > > As defined in the parent issue, store the states of each collection under > /collections/collectionname/state.json node -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org