[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062874#comment-14062874
]
Hoss Man commented on SOLR-2894:
--------------------------------
Hey Andrew, I probably won't have a chance to review this issue/patches again
until monday - but some quick replies...
bq. With the OVERREQUEST options uncommented we do not get the proper bbc value
and so the distributed version diverges from the non-distrib. Your second
comment on this issue is exactly on point.
Just to clarify: you are saying that bbc isn't included in the "top" set in the
distrib call because overrequest is so low, which is inconcsistent with the
control where bbc is in the top -- but all of the values returned by the
distrib call do in fact have accurate refined counts ... correct?
The point of that check is to definitely ensure that refinement works properly
on facet.missing -- that's why i added it, because it wasn't before and the
test didn't catch it because of the default overrequest -- so we can't
eliminate those OVERREQUEST params.
what we can do is explicitly call {{queryServer(...)}} instead of
{{query(...)}} to ht a random distributed server bu bypass the comparison with
the control server -- in that case though we want a lot of tight assertions to
ensure that we aren't missing anything.
(of course: we can also include another check of the same facet.missing request
with the overrequest disabled if you want -- no one ever complained about too
many assertions in a test)
bq. Should facet.missing respect the mincount (in this case it's 1)?
I think so? .. if that's what the non-distrib code is doing, that's what the
distrib code should do as well.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894_cloud_test.patch,
> dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
