[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065685#comment-14065685
]
Hoss Man commented on SOLR-2894:
--------------------------------
bq. Previously refinement requests would return counts of zero for things that
it was asked about but had no values for, this is now no longer true. (It
shrinks the required work to merge in refinements and limits how much data we
send across the wire). This means that we cannot ask if a refinement has been
fulfilled because if a shard doesn't know about a valuePath it will not include
it in its response.
So if i'm understanding correctly:
Old code:
* expected every shard to reply back with a number (at least 0) for every
refinement
* if it didnt' have a number fro ma shard, it asked again - infinite loop risk
New Code:
* expects every shard to reply back with a number for any refinement it has a
non-0 count for
* implicitly assumes a refinement has been fulfilled if it knows it already
asked.
..so it sounds like you already eliminated the underlying risk .. correct?
bq. So really the only thing we can check is that the facet_pivot isn't null on
a response, since that would indicate that something really awful happened.
yeah ... sounds good: we know this shard request asked for pivot refinements,
if the response doesn't at least contain a {{facet_pivot}} response then throw
a server error.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894_cloud_test.patch, dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
