[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2894:
---------------------------
Attachment: SOLR-2894.patch
I've finished reviewing all the code and didn't find any new concerns. (woot!)
I was hoping that more refactoring could be done to share common logic between
the facet.field distributed code and the facet.pivot distributed code (akin to
what it seemed like "applyToShardRequests()" was aiming for in earlier patches)
but between the use of the "DistribFieldFacet" class and the anoying
discrepency between "facet.mincount" and "facet.pivot.mincount" that seemed
like more trouble then it's worth.
In addition, my little-laptop-that-could has been churning away of several
hundred iterations of TestCloudPivots using tests.nightly=true with this patch
for the past few days, w/o any signs of bugs in the refinement code.
At this point, there are only a handful of 'nocommit' comments left in the
patch, that fall into 2 basic categories:
* methods/variables I still want to rename
* reminders to create new jira's to track known issues / future improvements
I plan to deal with those over the next 24 hours, but none of those changes
should have any impact on the functionality / performance of the patch as it
currently stands.
[~brett.lucey] & [~andrew.muldowney]: I'd really appreciate it if you guys
could take a gander at the latest version(s) of the patch and give my any
thoughts you have.
In particular: i know you've been using an older patch in production for a
while now, could you take this latest version for a spin using some of your
real data & queries and set my mind at ease that i haven't introduced any
horrible performance problems with any of hte refacotring/code cleanup / bug
fixes i've made?
{panel:title=Changes in this patch}
* TestCloudPivotFacet
** a bit more logging
** dial back overrequest w/ comment (we're focused on refinement here)
** fix the num iters = 5 (no need to be higher on nightly runs, already
increase the index size & num values per field)
* DistributedFacetPivotLargeTest
** new commented out test of "limit=0 + mincount=0 + missing=true"
*** i had a concern about this edge case w/refinement, but it turns out this
isn't evensupported in the existing pivot code.
* FacetComponent
** minor formatting & comment cleanup
** use PIVOT_KEY consistently throughout file
** rename pivotPrefix -> PIVOT_REFINE_PREFIX; and move to top of file
** move pivotRefinementCounter to top of file and add javadocs
** tweaked handleResponses:
*** check PURPOSE_REFINE_FACETS and PURPOSE_REFINE_PIVOT_FACETS in seperate if
blocks (instead of "else if"
*** doesn't change much at the moment, but smelled like a time bomb if/when we
ever do pivot refinement in the same requests as facet.field refinement.
** refactor away sanityCheckRefinements method
*** all it was doing was a single null check, so I inlined that
** use emptyList() in createPivotFacetOutput
** tweak variable names in createPivotFacetOutput
* PivotFacetProcessor
** clean up nocommits related to using FieldType methods where appropriate
** javadoc linting
* PivotFacetField
** trim() javadocs & comment about future optimization
** javadoc linting
* PivotFacetValueCollection
** trim() javadocs
** javadoc linting
* PivotFacet
** javadoc linting
* PivotFacetValue
** javadoc linting
{panel}
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894_cloud_test.patch, dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
