[ https://issues.apache.org/jira/browse/LUCENE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132949#comment-14132949 ]
Alan Woodward commented on LUCENE-5945: --------------------------------------- This looks ace. One nit: in FilesystemResourceLoader.java {code} throw new IllegalArgumentException("baseDirectory is not a directory") {code} should be {code} throw new IllegalArgumentException(baseDirectory + " is not a directory") {code} > Full cutover to Path api from java.io.File > ------------------------------------------ > > Key: LUCENE-5945 > URL: https://issues.apache.org/jira/browse/LUCENE-5945 > Project: Lucene - Core > Issue Type: Task > Reporter: Robert Muir > Attachments: LUCENE-5945.patch, LUCENE-5945_core.patch > > > Using NIO2 has a lot of benefits: > * more fine grained exception handling > * clearer semantics about what happens > * additional functionality > * possibility to work with virtual filesystems, etc. > We already banned File.delete and switched to Files.delete, I think we should > ban File completely (except for some sugar methods that just forward with > .toPath, like FSDirectory.open) > For tests, ideally we go a little further and ban methods like > FileSystems.getDefault(). Instead we could exempt LuceneTestCase and ensure > all Paths are created via one protected method. This leaves open the > possibility to mock up filesystem behavior at a lower level in tests in the > future. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org