[
https://issues.apache.org/jira/browse/LUCENE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132961#comment-14132961
]
Robert Muir commented on LUCENE-5945:
-------------------------------------
{quote}
If you have quesions, I might take care tomorrow. I found out that if/unless
works with filesets include directive only a few days ago:
https://ant.apache.org/manual/Types/patternset.html
{quote}
I will commit this patch and leave that to you. I don't want to refactor the
current forbidden APIs logic in this issue. Its already a 500KB patch.
{quote}
One nit: in FilesystemResourceLoader.java
{quote}
Thank you Alan.
> Full cutover to Path api from java.io.File
> ------------------------------------------
>
> Key: LUCENE-5945
> URL: https://issues.apache.org/jira/browse/LUCENE-5945
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-5945.patch, LUCENE-5945_core.patch
>
>
> Using NIO2 has a lot of benefits:
> * more fine grained exception handling
> * clearer semantics about what happens
> * additional functionality
> * possibility to work with virtual filesystems, etc.
> We already banned File.delete and switched to Files.delete, I think we should
> ban File completely (except for some sugar methods that just forward with
> .toPath, like FSDirectory.open)
> For tests, ideally we go a little further and ban methods like
> FileSystems.getDefault(). Instead we could exempt LuceneTestCase and ensure
> all Paths are created via one protected method. This leaves open the
> possibility to mock up filesystem behavior at a lower level in tests in the
> future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
