[
https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135225#comment-14135225
]
Uwe Schindler commented on LUCENE-5952:
---------------------------------------
bq. I don't think this should wait for 5.0
Just not in 4.10.1, we just have a bugfix release and the whole thing did not
change since 4.0. We can change that for 4.11, but as Robert suggested to
release 4.11 as 5.0 (after copy branch and merge some more stuff in), I wrote
"5.0".
bq. what if we want to later change that format it wrote? We already put this
burden on the codec formats, so I think leaving the burden in
Lucene46SegmentInfoFormat is the right place...
I am fine with that too. To me writing a version is like writing a String in
DataOutput, which is also a method outside of codecs.
> Make Version.java lenient again?
> --------------------------------
>
> Key: LUCENE-5952
> URL: https://issues.apache.org/jira/browse/LUCENE-5952
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.10
> Reporter: Michael McCandless
> Priority: Blocker
> Fix For: 4.10.1, 4.11, 5.0
>
> Attachments: LUCENE-5952.patch, LUCENE-5952.patch
>
>
> As discussed on the dev list, it's spooky how Version.java tries to fully
> parse the incoming version string ... and then throw exceptions that lack
> details about what invalid value it received, which file contained the
> invalid value, etc.
> It also seems too low level to be checking versions (e.g. is not future proof
> for when 4.10 is passed a 5.x index by accident), and seems redundant with
> the codec headers we already have for checking versions?
> Should we just go back to lenient parsing?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
