[
https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135230#comment-14135230
]
Robert Muir commented on LUCENE-5952:
-------------------------------------
I don't think its useful for Version to be picky here in any way.
this stuff only even executes if we successfully loaded the codec
(Codec.forName) and then invoked its .si reader. If Codec.forName succeeded
then we should be supporting the index.
Also, if a user has a 4.3 index and they go to 4.3.1 and the format hasnt
changed, why prevent them from rolling backwards to 4.3? There is no need for
that.
-1 to it throwing IndexFormatTooOld/New for this reasons from here. It makes no
sense.
> Make Version.java lenient again?
> --------------------------------
>
> Key: LUCENE-5952
> URL: https://issues.apache.org/jira/browse/LUCENE-5952
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.10
> Reporter: Michael McCandless
> Priority: Blocker
> Fix For: 4.10.1, 4.11, 5.0
>
> Attachments: LUCENE-5952.patch, LUCENE-5952.patch
>
>
> As discussed on the dev list, it's spooky how Version.java tries to fully
> parse the incoming version string ... and then throw exceptions that lack
> details about what invalid value it received, which file contained the
> invalid value, etc.
> It also seems too low level to be checking versions (e.g. is not future proof
> for when 4.10 is passed a 5.x index by accident), and seems redundant with
> the codec headers we already have for checking versions?
> Should we just go back to lenient parsing?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
