[
https://issues.apache.org/jira/browse/LUCENE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972981#action_12972981
]
Paul Elschot commented on LUCENE-2824:
--------------------------------------
In case I understood the javaspecialists article correctly, it could be faster
to use AIOOBE but only when -XX:-OmitStackTraceInFastThrow is not used in the
sun/oracle jvm. For the first few hundreds of exceptions from the same piece of
code however it would always be slower.
Since this depends on the JVM I'd rather keep the explicit bounds check in the
code for now, and may be open a separate issue when it turns out to be faster
to use AIOOBE.
> optimizations for bufferedindexinput
> ------------------------------------
>
> Key: LUCENE-2824
> URL: https://issues.apache.org/jira/browse/LUCENE-2824
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2824.patch
>
>
> along the same lines as LUCENE-2816:
> * the readVInt/readVLong/readShort/readInt/readLong are not optimal here
> since they defer to readByte. for example this means checking the buffer's
> bounds per-byte in readVint instead of per-vint.
> * its an easy win to speed this up, even for the vint case: its essentially
> always faster, the only slower case is 1024 single-byte vints in a row, in
> this case we would do a single extra bounds check (1025 instead of 1024)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
