[ 
https://issues.apache.org/jira/browse/LUCENE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984326#action_12984326
 ] 

Michael McCandless commented on LUCENE-2824:
--------------------------------------------

I'm seeing excellent gains w/ this patch, on Linux 64bit Java 6 NIOFSDir:

||Query||QPS clean||QPS robspec||Pct diff||||
|spanFirst(unit, 5)|16.67|15.62|{color:red}-6.3%{color}|
|"unit state"|8.04|7.87|{color:red}-2.2%{color}|
|spanNear([unit, state], 10, true)|4.31|4.25|{color:red}-1.2%{color}|
|"unit state"~3|4.85|5.02|{color:green}3.6%{color}|
|unit state|10.35|10.94|{color:green}5.7%{color}|
|unit~1.0|9.60|10.15|{color:green}5.7%{color}|
|unit~2.0|9.35|9.94|{color:green}6.3%{color}|
|united~2.0|3.30|3.51|{color:green}6.4%{color}|
|+nebraska +state|161.71|174.23|{color:green}7.7%{color}|
|+unit +state|11.20|12.09|{color:green}8.0%{color}|
|doctitle:.*[Uu]nited.*|3.93|4.25|{color:green}8.0%{color}|
|united~1.0|15.12|16.39|{color:green}8.4%{color}|
|un*d|49.33|56.09|{color:green}13.7%{color}|
|u*d|14.85|16.97|{color:green}14.3%{color}|
|state|25.95|30.12|{color:green}16.1%{color}|
|unit*|22.72|26.88|{color:green}18.3%{color}|
|uni*|12.64|15.20|{color:green}20.2%{color}|
|doctimesecnum:[10000 TO 60000]|8.42|10.73|{color:green}27.4%{color}|

+1 to commit.

> optimizations for bufferedindexinput
> ------------------------------------
>
>                 Key: LUCENE-2824
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2824
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.1, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-2824.patch
>
>
> along the same lines as LUCENE-2816:
> * the readVInt/readVLong/readShort/readInt/readLong are not optimal here 
> since they defer to readByte. for example this means checking the buffer's 
> bounds per-byte in readVint instead of per-vint.
> * its an easy win to speed this up, even for the vint case: its essentially 
> always faster, the only slower case is 1024 single-byte vints in a row, in 
> this case we would do a single extra bounds check (1025 instead of 1024)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to