[ https://issues.apache.org/jira/browse/SOLR-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229012#comment-14229012 ]
ASF subversion and git services commented on SOLR-6680: ------------------------------------------------------- Commit 1642511 from [~dsmiley] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642511 ] SOLR-6680: DefaultSolrHighlighter: avoid CachingTokenFilter when not needed > DefaultSolrHighlighter can sometimes avoid CachingTokenFilter > ------------------------------------------------------------- > > Key: SOLR-6680 > URL: https://issues.apache.org/jira/browse/SOLR-6680 > Project: Solr > Issue Type: Improvement > Components: highlighter > Reporter: David Smiley > Assignee: David Smiley > Fix For: 5.0 > > Attachments: SOLR-6680.patch, SOLR-6680.patch > > > The DefaultSolrHighlighter (the most accurate one) is a bit over-eager to > wrap the token stream in a CachingTokenFilter when > hl.usePhraseHighlighter=true. This wastes memory, and it interferes with > other optimizations -- LUCENE-6034. Furthermore, the internal > TermOffsetsTokenStream (used when TermVectors are used with this) wasn't > properly delegating reset(). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org