[ 
https://issues.apache.org/jira/browse/SOLR-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256588#comment-14256588
 ] 

ASF subversion and git services commented on SOLR-6680:
-------------------------------------------------------

Commit 1647481 from [~dsmiley] in branch 'dev/trunk'
[ https://svn.apache.org/r1647481 ]

SOLR-6680: refactor DefaultSolrHighlighter.TermOffsetsTokenStream (from term 
vectors) to avoid buffering the token.

> DefaultSolrHighlighter can sometimes avoid CachingTokenFilter
> -------------------------------------------------------------
>
>                 Key: SOLR-6680
>                 URL: https://issues.apache.org/jira/browse/SOLR-6680
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6680.patch, SOLR-6680.patch, 
> SOLR-6680_Solr_Highligher,_part_2,_OffsetWindowTokenFilter.patch
>
>
> The DefaultSolrHighlighter (the most accurate one) is a bit over-eager to 
> wrap the token stream in a CachingTokenFilter when 
> hl.usePhraseHighlighter=true.  This wastes memory, and it interferes with 
> other optimizations -- LUCENE-6034.  Furthermore, the internal 
> TermOffsetsTokenStream (used when TermVectors are used with this) wasn't 
> properly delegating reset().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to