[
https://issues.apache.org/jira/browse/LUCENE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250332#comment-14250332
]
Robert Muir commented on LUCENE-5951:
-------------------------------------
{quote}
...I don't see anything in the javadocs for FileStore making any guarantees
about the toString – so the results of these lastIndexOf and indexOf calls
should probably have bounds checks to prevent IOOBE from substring. (either
that or just catch the IOOBE and give up)
{quote}
Maybe you missed the try-catch when looking at the patch.
{code}
} catch (Exception ioe) {
// our crazy heuristics can easily trigger SecurityException, AIOOBE, etc ...
return true;
}
{code}
{quote}
...what about people with lots of partitions? ie: "/dev/sda42"
{quote}
Maybe if you quoted more of the context, you would see this was in a loop?
> Detect when index is on SSD and set dynamic defaults
> ----------------------------------------------------
>
> Key: LUCENE-5951
> URL: https://issues.apache.org/jira/browse/LUCENE-5951
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Attachments: LUCENE-5951.patch, LUCENE-5951.patch, LUCENE-5951.patch,
> LUCENE-5951.patch, LUCENE-5951.patch
>
>
> E.g. ConcurrentMergeScheduler should default maxMergeThreads to 3 if it's on
> SSD and 1 if it's on spinning disks.
> I think the new NIO2 APIs can let us figure out which device we are mounted
> on, and from there maybe we can do os-specific stuff e.g. look at
> /sys/block/dev/queue/rotational to see if it's spinning storage or not ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
