[
https://issues.apache.org/jira/browse/LUCENE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250600#comment-14250600
]
Hoss Man commented on LUCENE-5951:
----------------------------------
bq. Maybe you missed the try-catch when looking at the patch.
that still seems sketchy because it's only in the spins() method ... it's going
to be trappy if/when this code gets refactored and getDeviceName is called from
somewhere else. why not just include some basic exception handling in
getDeviceName as well?
bq. Maybe if you quoted more of the context, you would see this was in a loop?
I did see that, but i didn't realize the purpose was to chomp away at
individual digits in the path until it resolved as a valid file...
too much voodoo for me, i'll shut up now.
> Detect when index is on SSD and set dynamic defaults
> ----------------------------------------------------
>
> Key: LUCENE-5951
> URL: https://issues.apache.org/jira/browse/LUCENE-5951
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Attachments: LUCENE-5951.patch, LUCENE-5951.patch, LUCENE-5951.patch,
> LUCENE-5951.patch, LUCENE-5951.patch
>
>
> E.g. ConcurrentMergeScheduler should default maxMergeThreads to 3 if it's on
> SSD and 1 if it's on spinning disks.
> I think the new NIO2 APIs can let us figure out which device we are mounted
> on, and from there maybe we can do os-specific stuff e.g. look at
> /sys/block/dev/queue/rotational to see if it's spinning storage or not ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
