[ https://issues.apache.org/jira/browse/LUCENE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980241#action_12980241 ]
Robert Muir commented on LUCENE-2846: ------------------------------------- bq. But I think that's orthogonal to the improvements here? Ie this issue removes fake norms, invalid uses of default Sim, etc. Right, after talking to Grant, I think his comments are on the larger issues of norms... I am totally not trying to address this here. This one is just about cleaning up things that are "buggy", especially using Similarity.getDefault when we shouldn't. The scope of this one (even though its just cleanup) is large enough I think... I'd like to proceed with this unless there are any objections. We can address real improvements to norms somewhere else, and hopefully this will help make that easier. > omitTF is viral, but omitNorms is anti-viral. > --------------------------------------------- > > Key: LUCENE-2846 > URL: https://issues.apache.org/jira/browse/LUCENE-2846 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2846.patch, LUCENE-2846.patch, LUCENE-2846.patch, > LUCENE-2846.patch > > > omitTF is viral. if you add document 1 with field "foo" as omitTF, then > document 2 has field "foo" without omitTF, they are both treated as omitTF. > but omitNorms is the opposite. if you have a million documents with field > "foo" with omitNorms, then you add just one document without omitting norms, > now you suddenly have a million 'real norms'. > I think it would be good for omitNorms to be viral too, just for consistency, > and also to prevent huge byte[]'s. > but another option is to make omitTF anti-viral, which is more "schemaless" i > guess. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org