[
https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287208#comment-14287208
]
Michael McCandless commented on SOLR-6902:
------------------------------------------
I'm trying to dig into why the linter is upset by this patch ... but the patch
fails to apply to current 5.x branch (at least 9 of the files match "patch"
upset). Is there a newer version of the patch that applies? Or maybe we could
commit this to a branch and I could run from there?
> Use JUnit rules instead of inheritance with distributed Solr tests to allow
> for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-6902.patch, SOLR-6902.patch, SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test
> method in all distributed Solr tests (anything inheriting from
> {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods
> within the same class, and doesn't split tests as yet or flatten the
> inheritance hierarchy (when abused for doing multiple tests), as this touches
> a lot of files by itself. For that reason, the sooner this is picked up the
> better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
