[ 
https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288024#comment-14288024
 ] 

Erick Erickson commented on SOLR-6902:
--------------------------------------

[~mikemccand] Thanks! 

As Ram says, the half-life of this patch is short. I'd been keeping my copy up 
to date pretty much daily until Alan's check-in for removing support for 
old-style XML broke the easy updates. That code had to hit the test framework 
pretty heavily and I pretty much expected to have to update this patch as a 
result. Wish I'd been disappointed ;)

It's on my list today/tonight unless interrupts occur or [~andyetitmoves] gets 
there first.

> Use JUnit rules instead of inheritance with distributed Solr tests to allow 
> for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6902
>                 URL: https://issues.apache.org/jira/browse/SOLR-6902
>             Project: Solr
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Ramkumar Aiyengar
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-6902.patch, SOLR-6902.patch, SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test 
> method in all distributed Solr tests (anything inheriting from 
> {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods 
> within the same class, and doesn't split tests as yet or flatten the 
> inheritance hierarchy (when abused for doing multiple tests), as this touches 
> a lot of files by itself. For that reason, the sooner this is picked up the 
> better..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to