[ https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485337#comment-14485337 ]
Shawn Heisey commented on SOLR-7355: ------------------------------------ My svn version is 1.8.8 (newest seems to be 1.8.13). I see that "svn stat" classifies the new license files for Caffeine as moves, but "svn diff" is not including those moves in the patch. [~markrmil...@gmail.com], can you comment on ConcurrentLinkedHashMap usage in Solr's HDFS support and whether it would be worthwhile to switch to this library from [~ben.manes]? My local trunk checkout is ready for a commit, if you think it's a good idea. Both precommit and solr tests are passing. > Java 8: ConcurrentLinkedHashMap -> Caffeine > ------------------------------------------- > > Key: SOLR-7355 > URL: https://issues.apache.org/jira/browse/SOLR-7355 > Project: Solr > Issue Type: Task > Reporter: Ben Manes > Priority: Minor > Attachments: SOLR-7355.patch, SOLR-7355.patch > > > When Solr transitions to requiring Java 8, please upgrade to Caffeine. The > performance should be relatively the same. The per-instance memory usage > should be smaller and Solr may decide to opt-in to use some of the additional > features. The only drawback is that the jar size is larger due to code > generation, though that may be trimmed over time and usually is not a concern > for server-side applications. > ConcurrentLinkedHashMap changes will continue to be minimal, even more so > now, and driven by requests from Java 6 users unable to upgrade. Caffeine is > ideally the upgrade path for Guava cache users too, which due to Android > cannot be significantly modified. > Caffeine: https://github.com/ben-manes/caffeine > Benchmarks: https://github.com/ben-manes/caffeine/wiki/Benchmarks > ConcurrentLinkedHashMap: https://code.google.com/p/concurrentlinkedhashmap -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org