[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485467#comment-14485467
]
Shawn Heisey commented on SOLR-7355:
------------------------------------
When I tried to commit, I got an error message about "Inconsistent line ending
style". The same error has been happening on "svn diff".
I've redone the change as straight adds and deletes, no moves. That got rid of
the message on "svn diff". Checking precommit and tests again just to be sure
I haven't made a mistake.
> Java 8: ConcurrentLinkedHashMap -> Caffeine
> -------------------------------------------
>
> Key: SOLR-7355
> URL: https://issues.apache.org/jira/browse/SOLR-7355
> Project: Solr
> Issue Type: Task
> Reporter: Ben Manes
> Priority: Minor
> Attachments: SOLR-7355.patch, SOLR-7355.patch, SOLR-7355.patch
>
>
> When Solr transitions to requiring Java 8, please upgrade to Caffeine. The
> performance should be relatively the same. The per-instance memory usage
> should be smaller and Solr may decide to opt-in to use some of the additional
> features. The only drawback is that the jar size is larger due to code
> generation, though that may be trimmed over time and usually is not a concern
> for server-side applications.
> ConcurrentLinkedHashMap changes will continue to be minimal, even more so
> now, and driven by requests from Java 6 users unable to upgrade. Caffeine is
> ideally the upgrade path for Guava cache users too, which due to Android
> cannot be significantly modified.
> Caffeine: https://github.com/ben-manes/caffeine
> Benchmarks: https://github.com/ben-manes/caffeine/wiki/Benchmarks
> ConcurrentLinkedHashMap: https://code.google.com/p/concurrentlinkedhashmap
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
