[ 
https://issues.apache.org/jira/browse/LUCENE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499488#comment-14499488
 ] 

Uwe Schindler commented on LUCENE-6420:
---------------------------------------

[~simonw] did include the new Annotation support of forbiddenapis 1.8 into 
elasticsearch: [https://github.com/elastic/elasticsearch/pull/10560/files]
We can do the same in Lucene, so we have a more fine-granular exclusion pattern 
than the current file-level exclusions. I also like his "reason" on his 
annotation, so you can/have to give a reason why you apply 
{{@SuppressForbidden}}.
I would suggest to add this annotation to lucene-core.jar as class level, non 
runtime annotation. I can work on that next week.

> Update forbiddenapis to 1.8
> ---------------------------
>
>                 Key: LUCENE-6420
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6420
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Trunk, 5.2
>
>         Attachments: LUCENE-6420.patch
>
>
> Update forbidden-apis plugin to 1.8:
> - Initial support for Java 9 including JIGSAW
> - Errors are now reported sorted by line numbers and correctly grouped 
> (synthetic methods/lambdas)
> - Package-level forbids: Deny all classes from a package: org.hatedpkg.** 
> (also other globs work)
> - In addition to file-level excludes, forbiddenapis now supports fine 
> granular excludes using Java annotations. You can use the one shipped, but 
> define your own, e.g. inside Lucene and pass its name to forbidden (e.g. 
> using a glob: **.SuppressForbidden would any annotation in any package to 
> suppress errors). Annotation need to be on class level, no runtime annotation 
> required.
> This will for now only update the dependency and remove the additional forbid 
> by [~shalinmangar] for MessageFormat (which is now shipped with forbidden). 
> But we should review and for example suppress forbidden failures in command 
> line tools using @SuppressForbidden (or similar annotation). The discussion 
> is open, I can make a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to