[
https://issues.apache.org/jira/browse/LUCENE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502334#comment-14502334
]
Steve Rowe commented on LUCENE-6420:
------------------------------------
About the maven config:
{{lucene/test-framework/pom.xml.template}} and
{{solr/core/src/test/pom.xml.template}} aren't modified, but likely should be -
I think the specializations there can be removed.
{{lucene/benchmark/pom.xml.template}} and {{lucene/demo/pom.xml.template}}
should probably have {{lucene.txt}} added to their {{<signaturesFiles>}}.
Also, if I understand how things are setup, the new annotation suppresses all
forms of forbiddenapi checking, as compared to the previous configuration,
where there were multiple executions, and exceptions were targetted at a
particular check (e.g. sysout), but didn't prevent other checks from running.
In the maven build this represents a loss of coverage everywhere the
annoatations are used, doesn't it? Not sure about the Ant build.
> Update forbiddenapis to 1.8
> ---------------------------
>
> Key: LUCENE-6420
> URL: https://issues.apache.org/jira/browse/LUCENE-6420
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: Trunk, 5.2
>
> Attachments: LUCENE-6420-anno.patch, LUCENE-6420-anno.patch,
> LUCENE-6420.patch
>
>
> Update forbidden-apis plugin to 1.8:
> - Initial support for Java 9 including JIGSAW
> - Errors are now reported sorted by line numbers and correctly grouped
> (synthetic methods/lambdas)
> - Package-level forbids: Deny all classes from a package: org.hatedpkg.**
> (also other globs work)
> - In addition to file-level excludes, forbiddenapis now supports fine
> granular excludes using Java annotations. You can use the one shipped, but
> define your own, e.g. inside Lucene and pass its name to forbidden (e.g.
> using a glob: **.SuppressForbidden would any annotation in any package to
> suppress errors). Annotation need to be on class level, no runtime annotation
> required.
> This will for now only update the dependency and remove the additional forbid
> by [~shalinmangar] for MessageFormat (which is now shipped with forbidden).
> But we should review and for example suppress forbidden failures in command
> line tools using @SuppressForbidden (or similar annotation). The discussion
> is open, I can make a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
