[ 
https://issues.apache.org/jira/browse/SOLR-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504356#comment-14504356
 ] 

Hrishikesh Gadre commented on SOLR-7176:
----------------------------------------

Are you suggesting that CLI should run a retry loop? I would prefer not to 
retry automatically since it could overwrite some other directive of some other 
CLI invocation. In my current patch, I have added a check to see if the value 
is set correctly (after receiving an error). If it is, then the invocation is 
successful. If not, we fail the invocation. This also works in scenarios where 
two invocations attempt to set the same value.

Adding retries would also raise questions like - how many retries are 
sufficient? Is there an exponential backoff policy? What is the time interval 
between two retries etc. All of this can be implemented outside Solr very 
easily if required (e.g. a script can run the zkcli command in a loop until it 
succeeds).

> allow zkcli to modify JSON
> --------------------------
>
>                 Key: SOLR-7176
>                 URL: https://issues.apache.org/jira/browse/SOLR-7176
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Noble Paul
>            Priority: Minor
>         Attachments: SOLR-7176.patch, SOLR-7176.patch, SOLR-7176.patch
>
>
> To enable SSL, we have instructions like the following:
> {code}
> server/scripts/cloud-scripts/zkcli.sh -zkhost localhost:2181 -cmd put 
> /clusterprops.json '{"urlScheme":"https"}'
> {code}
> Overwriting the value won't work well when we have more properties to put in 
> clusterprops.  We should be able to change individual values or perhaps merge 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to