[
https://issues.apache.org/jira/browse/SOLR-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506567#comment-14506567
]
Per Steffensen commented on SOLR-7176:
--------------------------------------
bq. This would also be valid for NodeExistsException
Hmmm, believe you are right
bq. I also thought about it. But it seems like when ZkStateReader does not own
the ZK client (e.g. in CollectionsHandler), it shouldn't close it? Any thoughts?
ZkStateReader does not own the ZK client if you use the
{{ZkStateReader(SolrZkClient zkClient)}} constructor - and we do in all the
mentioned caces. And it does not close the ZK client on close, when it does not
own it. Hence in the mentioned cases calling close really does not do much,
except setting closed=true. I just thought it was the right thing to do - call
close when you create and finished using a closable component.
> allow zkcli to modify JSON
> --------------------------
>
> Key: SOLR-7176
> URL: https://issues.apache.org/jira/browse/SOLR-7176
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Noble Paul
> Priority: Minor
> Attachments: SOLR-7176.patch, SOLR-7176.patch, SOLR-7176.patch,
> SOLR-7176.patch
>
>
> To enable SSL, we have instructions like the following:
> {code}
> server/scripts/cloud-scripts/zkcli.sh -zkhost localhost:2181 -cmd put
> /clusterprops.json '{"urlScheme":"https"}'
> {code}
> Overwriting the value won't work well when we have more properties to put in
> clusterprops. We should be able to change individual values or perhaps merge
> values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
