[
https://issues.apache.org/jira/browse/LUCENE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511305#comment-14511305
]
Paul Elschot commented on LUCENE-6373:
--------------------------------------
My pleasure, thanks for benchmarking.
A last review found a no more used variable in nextStartPosition(), sorry:
{code}
diff --git
a/lucene/core/src/java/org/apache/lucene/search/spans/SpanOrQuery.java
b/lucene/core/src/java/org/apache/l
index eca3635..9d0d09a 100644
--- a/lucene/core/src/java/org/apache/lucene/search/spans/SpanOrQuery.java
+++ b/lucene/core/src/java/org/apache/lucene/search/spans/SpanOrQuery.java
@@ -288,8 +288,6 @@ public class SpanOrQuery extends SpanQuery implements
Cloneable {
@Override
public int nextStartPosition() throws IOException {
- DisiWrapper<Spans> topDocSpans = byDocQueue.top();
- assert topDocSpans.doc != NO_MORE_DOCS;
if (topPositionSpans == null) {
byPositionQueue.clear();
fillPositionQueue(); // fills byPositionQueue at first position
{code}
> Complete two phase doc id iteration support for Spans
> -----------------------------------------------------
>
> Key: LUCENE-6373
> URL: https://issues.apache.org/jira/browse/LUCENE-6373
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Fix For: Trunk, 5.2
>
> Attachments: LUCENE-6373-SpanOr.patch, LUCENE-6373.patch,
> LUCENE-6373.patch, LUCENE-6737-SpanOr-oneTestFails.patch,
> SpanPositionQueue.java
>
>
> Spin off from LUCENE-6308, see comments there from about 23 March 2015.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
