[ 
https://issues.apache.org/jira/browse/LUCENE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510447#comment-14510447
 ] 

Robert Muir commented on LUCENE-6373:
-------------------------------------

+1 for this patch, it is very nice. I love that now spans share both 
conjunction and disjunction logic and support two-phase execution everywhere. 

I benchmarked and found no performance regressions with a variety of tasks, 
like filter intersection with disjunctions, minshouldmatch queries, etc.

I created a contrived benchmark for SpanOr, "spanMultiPhrase" which just reuses 
the same tasks file from LUCENE-6421, but instead executes as SpanNear(SpanOr, 
...). It takes 15 minutes per iteration, and isn't the greatest benchmark but 
so far i see up to 10% improvement in some cases for that benchmark.

I will do some final tests and plan to commit this soon.

> Complete two phase doc id iteration support for Spans
> -----------------------------------------------------
>
>                 Key: LUCENE-6373
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6373
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>         Attachments: LUCENE-6373-SpanOr.patch, LUCENE-6373.patch, 
> LUCENE-6373.patch, LUCENE-6737-SpanOr-oneTestFails.patch, 
> SpanPositionQueue.java
>
>
> Spin off from LUCENE-6308, see comments there from about 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to